Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove DATEV integration #30584

Merged
merged 5 commits into from
Apr 13, 2022
Merged

refactor!: remove DATEV integration #30584

merged 5 commits into from
Apr 13, 2022

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Apr 5, 2022 •
edited by ankush
Loading

The DATEV integration follows the trend and moves into a separate app.

This was referenced Apr 6, 2022
Closed
Merged
@ankush
Copy link
Member

ankush commented Apr 6, 2022 •
edited
Loading

@barredterra conflicts are from #29783

Though there isn't any real "conflict" since all the conflicting files are deleted. Just gotta merge develop branch into it.

TODO:

  • Needs a patch to remove doctype/reports from database.
  • warning

@ankush ankush added the needs-patch A patch to fix existing data is required label Apr 6, 2022
@ankush ankush self-assigned this Apr 12, 2022
@ankush ankush changed the title feat: remove DATEV integration refactor!: remove DATEV integration Apr 13, 2022
@ankush ankush added squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. and removed needs-patch A patch to fix existing data is required labels Apr 13, 2022
@ankush ankush marked this pull request as ready for review April 13, 2022 08:17
@ankush ankush mentioned this pull request Apr 13, 2022
Merged
@mergify mergify bot merged commit 6453fb4 into frappe:develop Apr 13, 2022
@barredterra barredterra deleted the remove-datev-csv branch April 13, 2022 09:26
mergify bot pushed a commit that referenced this pull request Apr 13, 2022
@ankush
chore(deps)!: Drop pandas as dependency (#30598)
0f09042 
depends on #30597
depends on #30584 


Closes #27047 (read for more details)
@deepeshgarg007 deepeshgarg007 mentioned this pull request May 9, 2022
Open
@deepeshgarg007 deepeshgarg007 mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankush ankush ankush approved these changes

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@marination marination Awaiting requested review from marination

Assignees

@ankush ankush

Labels
squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barredterra @ankush